search

rsalmei / alive-progress

A new kind of Progress Bar, with real-time throughput, ETA, and very cool animations!
MIT License
5.45k stars 205 forks source link

Slight changes to unknown mode's output #190

Closed djordje-kalojevic closed 1 year ago

djordje-kalojevic commented 2 years ago

Small changes that make the progress bar output a bit more suitable for an indeterminate (unknown) mode

rsalmei commented 1 year ago

Hi, the first change is a bug, already fixed in the new upcoming version. And the second one I don't get it, why would you remove the prefix in from the elapsed line when we don't have a total??

djordje-kalojevic commented 1 year ago

Hi,

First of all, thank you for reaching out, I have attached a few images from back when I made those changes, it might be easier to show it than explain it. There are two parts to my changes:

1) The "(!)" was displayed when a single item was successfully processed despite me passing nothing as the "total" parameter, hence the "and total is not None", with this it no longer appears.

2) As for "in" it could stay but since there is already an option for the user to add to it, they could add it if needed.

Happy to discuss this further so feel free to email me any time.

Best regards,

On Sun, Dec 18, 2022 at 9:26 PM Rogério Sampaio de Almeida < @.***> wrote:

Hi, the first change is a bug, already fixed in the new upcoming version. And the second one I don't get it, why would you remove the prefix in from the elapsed line when we don't have a total??

— Reply to this email directly, view it on GitHub https://github.com/rsalmei/alive-progress/pull/190#issuecomment-1356869064, or unsubscribe https://github.com/notifications/unsubscribe-auth/A24YWE3BW425W2XRYTCPMD3WN5XPNANCNFSM6AAAAAAQLREEYM . You are receiving this because you authored the thread.Message ID: @.***>

TheTechRobo commented 1 year ago

FYI, email attachments dont seem to work with github.

rsalmei commented 1 year ago

I see, thanks @djordje-kalojevic. As I had said, the 1) was already fixed here in my new version, and regarding the 2), although I do agree with you that the user could already insert it, he can also remove it if desired the same way... And I think that, for a default value, it is more useful to keep it in there, so I'll close this one, ok? Thank you anyway!