python 3.5, 3.6+ changes

rsalmei / alive-progress

A new kind of Progress Bar, with real-time throughput, ETA, and very cool animations!

MIT License

5.45k stars 205 forks source link

python 3.5, 3.6+ changes #210

Closed marksmayo closed 1 year ago

marksmayo commented 1 year ago

trailing commas added where required
illegal trailing commas removed
imports cleaned up
indentation tidy
black formatting

all 532 tests passed

rsalmei commented 1 year ago

Thank you for your work @marksmayo, but I can't accept it. I don't like black's formatting, especially using double quotes for strings... Also, my project already targets Python 3.5+, so there isn't any real gain here. I'm gonna close it, alright? Please don't be upset, and know I do appreciate the trouble you had to make it.

marksmayo commented 1 year ago

No problem, it's your repo and I just added after I'd played with it a bit. Thanks for your hard work too!

rsalmei commented 1 year ago

Thanks man!! 👍