search

rsalmei / alive-progress

A new kind of Progress Bar, with real-time throughput, ETA, and very cool animations!
MIT License
5.53k stars 206 forks source link

pacman style progressbar #37

Open FredBrockstedt opened 4 years ago

FredBrockstedt commented 4 years ago

if you like, adds a pacman style progressbar. Fixes some rounding issues and adds a demo file.

rsalmei commented 4 years ago

Hey @FredBrockstedt,

Thanks for the PR! But please, could you send only the bug fix? I do not want a demo.py in the root project, nor the pacman bar, which I think do not fit with the concept. It could be a cool Customization tutorial in the readme for example, but not actually builtin I think.

I will think about a contrib package or something like it, to enable user contributed content, in which case I would like very much to have your pacman bar...

FredBrockstedt commented 4 years ago

Hey Rogerio,

it’s an offer, if the answer is no, it’s perfectly fine. I left the request open to edit, so feel free to throw out anything you like. If people are interested, they can alway pull it from my fork.

I’m happy to provide you with a pull request, adapted to your likings. My feeling is, we both save a lot of time, if you add the cast to int [1] yourself, as it is a very simple fix.

More choice in progress bars is definitely a good thing, so I’m looking forward to having user contributed bars in the future.

I understand your choice about the demo file. It makes for a clean library, I wonder how many of the alive-progress users created a similar file, by copying code form the readme, just to see if it will work on their system? As a library user, I’m always happy to have a small main or demo file to quickly see how the library performs on my system. But that’s just my personal preference.

Stay healthy in theses Corona times.

[1] https://github.com/rsalmei/alive-progress/pull/37/commits/df8bf4aad31ddf6ce51e2a1f4908ad7f9d3e1789

On 3. May 2020, at 23:48, Rogério Sampaio de Almeida notifications@github.com wrote:

Hey @FredBrockstedt https://github.com/FredBrockstedt,

Thanks for the PR! But please, could you send only the bug fix? I do not want a demo.py in the root project, nor the pacman bar, which I think do not fit with the concept. It could be a cool Customization tutorial em readme also.

I will think about a contrib package or something like it, to enable user contributed content, in which case I would like very much to have your pacman bar...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rsalmei/alive-progress/pull/37#issuecomment-623187742, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2DDPQEH3WO5YYDOCN5P33RPXRDXANCNFSM4MYD4QXQ.

rsalmei commented 4 years ago

Hey @FredBrockstedt,

Thank you for your words, I've fixed that bug myself, and released 1.5.1 yesterday. Also I understand your point about a demo, but still prefer a clean library with a good readme, so people can approach it gently.

I think you titled this PR very appropriately, it is about a new progressbar style. I'm thinking very carefully about how to contribute bars, spinners and themes in a simple way, and this PR could be its test and debut.

I've thought about a cool system with separate packages, so people would be able to pip install cool-bars to get that package. alive_progress would find this package via pkg_resources, and make the bars, spinners and themes in there available in both alive_bar and showtime exhibit. It is nice, and enables split repositories, but is more complex, requiring a setup.py and actually releasing it in PyPI. Very convoluted, not good.

So I think I'll just create a contrib package and some pattern for modules inside. Then I'll dynamically find all modules in the package, and make those resources available. A module will probably work as a namespace, so I could list available namespaces, and require one to showtime it.

What do you think, ideas, concerns?

TheTechRobo commented 3 years ago

What do you think, ideas, concerns?

Im not OP but I like that idea, tho imo the pip packages should start with "alive-progress-" for clarity.

rsalmei commented 3 years ago

Thanks @TheTechRobo. I'm still keeping this one open for a little while. I'd like very much to enable people's contributions, but in a simple way. After 2.0 I'll think harder about this. But please share ideas if you have any.

rsalmei commented 3 years ago

Hey @FredBrockstedt, how are you?

Look at that, your pacman bar is still reserved for a user contrib package somehow, but the demo idea has made it into 2.0! I've implemented a super cool and advanced demo, that showcases several scenarios! And I put it in a python module, because I figured a demo.py in the root would be very hard to call... Now it will be as simple as python -m alive_progress.tools.demo 👍 Here it is:

image

regards man!