Removed unused imports - Githubissues

rsalmei / alive-progress

A new kind of Progress Bar, with real-time throughput, ETA, and very cool animations!

MIT License

5.53k stars 206 forks source link

Removed unused imports #66

Closed UP929312 closed 3 years ago

rsalmei commented 3 years ago

Hey @UP929312, thank you. But yeah, those are actually needed, and no IDE should report them as unused, did yours warned you? Take for example the print_function future, it is extensively used, why did you think it was not used?

TheTechRobo commented 3 years ago

@rsalmei

extensively used

In python 2.x yes, so I'm assuming it'll work fine once version 2.0 is released ?? (doesn't support python 2.x) Correct me if im wrong.

rsalmei commented 3 years ago

Hey @TheTechRobo, Yes, in python 2 they are needed, in python 3 they are ignored, so no harm done. After 2.0 release they won't even exist, since I already removed them in the new code.

TheTechRobo commented 3 years ago

Should this PR be closed?

rsalmei commented 3 years ago

Yes! 👍