search

rsanchez-wsu / fa15-ceg3120

11 stars 2 forks source link

Possible Lazy-Man's Approach to Formatting #13

Closed pquackenbush closed 9 years ago

pquackenbush commented 9 years ago

I found within checkStyle that there is an option to use an experimental feature that will keep the checkStyle.xml synced with the eclipse formatter. I tested this against the NetworkManager class, and the only changes that would need to be made manually are the insertion of JavaDoc, adding curlies to the ifs, and reorg of the imports. (of course most of this could just be my personal settings, but man are the tabs huge :stuck_out_tongue_winking_eye: )

If you merge the HomeownerUIBase branch with your own, not only will you have all the common data objects, but .checkStyle.xml should be set to allow this behavior as well

pquackenbush commented 9 years ago

That last commit may cause some major headaches when merging as just about every file was affected... Please merge before any further development to prevent as many merge conflicts as possible.

Thanks

@LABurn @jakern @emilynovak @laanak08 @BrianTighe

samohtj commented 9 years ago

Didn't want to create a new issue, so I'm commenting here.

I've switched checkstyle so that it uses 4 space tabs as opposed to 8, and I have a good reason. With 8 space tabs, some of the lines of code already written stick out past the 100 character limits. Even if the tabs you use are actually 4 spaces, checkstyle still thinks they're 8. So, to prevent us having to split our lines of code and wrap them more than we should have to, I've switched everything so it runs on 4 space tabs.

Is this okay with everybody?

jakern commented 9 years ago

No problems here

On Sat, Sep 26, 2015, 12:45 Jonathan Thomas notifications@github.com wrote:

Didn't want to create a new issue, so I'm commenting here.

I've switched checkstyle so that it uses 4 space tabs as opposed to 8, and I have a good reason. With 8 space tabs, some of the lines of code already written stick out past the 100 character limits. Even if the tabs you use are actually 4 spaces, checkstyle still thinks they're 8. So, to prevent us having to split our lines of code and wrap them more than we should have to, I've switched everything so it runs on 4 space tabs.

Is this okay with everybody?

— Reply to this email directly or view it on GitHub https://github.com/rsanchez-wsu/fa15-ceg3120/issues/13#issuecomment-143469168 .

rsanchez-wsu commented 9 years ago

@samohtj I am in agreement.

pquackenbush commented 9 years ago

I think we've moved passed this.