rsanchez / json

Output ExpressionEngine data in JSON format.
http://devot-ee.com/add-ons/json/
101 stars 234 forks source link

Ensure that ee()->TMPL is not overwritten #62

Closed domstubbs closed 6 years ago

domstubbs commented 6 years ago

I posted a comment about this yesterday and thought I might as well submit a PR with the changes I’ve made locally. This does feel like a bit of a bodge, but the issue seems to have affected quite a few people (my guess is it’s the source of all missing tagparams problems) and this is proving to be a reliable fix for me.

rsanchez commented 6 years ago

Hi Dom,

I don't really work with EE anymore or have time to service this add-on. Can I give you write access to this repo so you can patch things yourself?

domstubbs commented 6 years ago

Sure, I can merge these in and commit a point update if you’re happy with the changes.

I’ve stopped developing with EE as well, but this plugin is proving invaluable for migrating content from an old site over to Craft.

I’ll be working on the migration over the next few days, so maybe it’s best if I wait and see if any other issues crop up, then merge these PRs and bump the version number once I’m done.

Thanks for your work on this btw, I’m using it with the FeedMe Craft plugin and it’s working a treat.

domstubbs commented 6 years ago

I’ve merged my PRs and committed a point update which also adds hooks for the entries and members methods.