Added support for Cardboard V2.0 style touch-triggers

sean-purcell commented 8 years ago

Also deprecated - (void)magneticTriggerPressed and added - (void)triggerPressed to be more generic.

rsanchezsaez commented 8 years ago

Hey @iburinoc, thanks a lot for your contribution, this is a worthwhile change.

Some comments:

Replacing -(void)magneticTriggerPressed by -(void)triggerPressed is fine. But I'd rather directly rename the methods instead of deprecating the old one. The change is very minor, so I think in this instance it's ok to break previous code.
I'd directly add the touch-as-trigger functionality to CBDViewController.mm/h, since this part is iOS specific rather than more generic as the rest of the C++ SDK. Also, I'd add a (on by default if you want) useTouchTrigger property to CBDViewController to optionally disable this feature.

If you do these changes I'll merge the pull request. :)

sean-purcell commented 8 years ago

That sounds reasonable, I implemented the changes :)

rsanchezsaez commented 8 years ago

Done, thanks a lot for your contribution!

rsanchezsaez / CardboardSDK-iOS