rsanchezsaez / CardboardSDK-iOS

iOS port of Google's CardboardSDK (mobile VR toolkit)
Other
334 stars 104 forks source link

Add SceneKit + SpriteKit example #24

Closed GuyDavis90 closed 8 years ago

GuyDavis90 commented 8 years ago

Basic project utilizing SceneKit for rendering a Collada (.dae) file. SpriteKit scene is applied as a texture to one of the Nodes. If you move the glClear to the beginning of the drawEyeWithEye function you will see how SpriteKit breaks the scissor and the left side of the screen gets cleared with every right drawEyeWithEye pass.

rsanchezsaez commented 8 years ago

Thanks for your contribution! This is a great example project to have.

I have added some comments. I'll be happy to merge this after you fix those. Also, feel free to add yourself to the AUTHORS.md file.

GuyDavis90 commented 8 years ago

@rsanchezsaez I've updated the PR with the changes you requested! :D For the glClear/Scissor Test issue I have only disabled it in that function since it's enabled again by the SDK code. It was an issue I noticed in my other project but I haven't figured out what is actually the cause yet.

rsanchezsaez commented 8 years ago

Thanks again for your quick reply! I have now merged this.

I took the liberty to make a small rewrite of your comments to make them more direct and succinct, let me know if you think its meaning is properly kept.

GuyDavis90 commented 8 years ago

Rewritten comments look good to me :D