search

rsbivand / rgrass

Interpreted interface between the GRASS geographical information system and R
https://rsbivand.github.io/rgrass/
24 stars 8 forks source link

Prepare **rgrass7** release with everything deprecated #67

Closed rsbivand closed 1 year ago

rsbivand commented 1 year ago

Hi @VLucet @hellik @florisvdh @veroandreo : if you could have a look at the rgrass7 branch - I've prepared 0.2-11 deprecating everything as we discussed earlier. Is this OK?

veroandreo commented 1 year ago

Hi @rsbivand, it seems ok to me. AFAIU, all functions receive the deprecated warning and those that changed names, make it explicit, right? Will this one be then the last rgrass7?

rsbivand commented 1 year ago

Not necessarily, but any subsequent versions before archiving would only be maintenance (for example asked for by CRAN or caused by changes in packages this package depends on).

hellik commented 1 year ago

@rsbivand it looks good.

florisvdh commented 1 year ago

Looks good indeed (have tried some locally) – the deprecation will be very obvious :+1:. Thanks a lot for doing all this work.

Assuming that the intention was to explicitly deprecate all exported functions, then some exported functions (below) aren't yet deprecated. Maybe it's a deliberate choice, since these are no primary functions.

gmeta2grd
getXMLencoding
setXMLencoding
getLocationProj
get.GIS_LOCK
set.GIS_LOCK
unset.GIS_LOCK
unlink_.gislock
remove_GISRC

In the rgrass7 branch, following files are clearly outdated, so it also seems appropriate to:

Both files are visible in the GitHub repo when switched to the rgrass7 branch: https://github.com/rsbivand/rgrass/tree/rgrass7.

And in the main branch (this does not apply to the next rgrass7 release), the last two bullets of .github/CONTRIBUTING.md – about the rgrass7 branch and rgrass7 package respectively – will need to be simplified/updated after the rgrass7 release.

rsbivand commented 1 year ago

Thanks, I'll add these and deprecate the missed monor exported functiond. The current state is now on CRAN, so some other corrections msy be needed if users respond.