search

rsbivand / rgrass

Interpreted interface between the GRASS geographical information system and R
https://rsbivand.github.io/rgrass/
26 stars 9 forks source link

attempting to address #72, XML to xml2 #81

Closed rsbivand closed 11 months ago

rsbivand commented 1 year ago

This needs testing in production settings exercising more GRASS commands and on Windows and macOS:

devtools::install_github("rsbivand/rgrass", "xml2")
rsbivand commented 12 months ago

@florisvdh thanks! The code changes are only in parseGRASS, converting the XML returned by --interface-description to the (cached) internal representation used by doGRASS and execGRASS. The added test checks that the current version with xml2 is the same as that created when using XML; the test is for r.out.gdal. Because xml2 is vectorised but XML isn't, the conversion isn't completely obvious, but https://gist.github.com/nuest/3ed3b0057713eb4f4d75d11bb62f2d66 was a useful starting point.

rsbivand commented 11 months ago

@veroandreo Thanks! I'll submit to CRAN when submissions re-open in January.