search

rsbivand / sunMaptools

Skeleton package to continue sun/solar functions and methods from maptools
1 stars 0 forks source link

CRAN release #2

Open adokter opened 1 year ago

adokter commented 1 year ago

Hi @rsbivand,

We've now set up an R CMD CHECK for this package here: https://github.com/adokter/suntools/

I had to disconnect it as a fork from this repo in order for that to work, and as part of that process I also renamed it to the shorter suntools

We still need to update the documentation generation, so it will be compatible with roxygen, but other than that we would like the functionality mostly as is, so it remains backward compatible.

Are there any other contributors we should consider, besides the original authors (you, Sebastian Luque and Greg Pelletier)? And would you be ok with us releasing this suntools package on CRAN in this form?

rsbivand commented 1 year ago

@adokter Thanks very much! Yes, releasing to CRAN will help the maintainers of the affected packages: birdscanR https://github.com/BirdScanCommunity/birdscanR/issues/3, PWFSLSmoke https://github.com/MazamaScience/PWFSLSmoke/issues/124, EMbC, FLightR https://github.com/eldarrak/FLightR/issues/24, and probably others. Please let me know when you are ready, and perhaps create PRs for packages needing to upgrade to suntools from maptools. I'll submit an updated maptools dropping the export of the affected functions to avoid multiple defined methods warnings from CRAN checks. So when you are ready to go, several of us will need to jump more ot less at the same time.

iskandari commented 1 year ago

hi @rsbivand, we are now ready to release suntools

rsbivand commented 1 year ago

I'll prepare a maptools submission without export of the functions and post here when ready.

iskandari commented 1 year ago

@rsbivand if sun-methods are no longer exported in the forthcoming version of maptools, is it OK to go ahead with the release of suntools ?

rsbivand commented 1 year ago

Please submit to CRAN including in the note that as soon as https://github.com/adokter/suntools/ is released, maptools will be submitted marking the methods as deprecated in favour of the new package. maptools cannot point to the new package before it is published on CRAN.

adokter commented 1 year ago

Hi @rsbivand, suntools is now on CRAN: https://cran.r-project.org/web/packages/suntools/index.html

rsbivand commented 1 year ago

Excellent! Thanks so much!