search

rsc-ontologies / rsc-cmo

Chemical Methods Ontology
Creative Commons Attribution 4.0 International
12 stars 7 forks source link

Import OBI's "sample preparation for assay" (OBI:0000073) & add new term "NMR sample preparation" as child #17

Closed hujo91 closed 2 years ago

hujo91 commented 2 years ago

closes #16

Hi @colinbatchelor, to solve this issue, I used the MIREOT plugin in Protégé to import OBI's "sample preparation for assay" (OBI:0000073) in the chmo.obo and then added the new term "NMR sample preparation" as a child. Afterwards I used ROBOT to convert the new chmo.obo into the chmo.owl (unfortunately mistyped at the 2nd commit, must be "make owl with robot" instead of "make obo with robot").

Please have a look at this. Many Thanks!

Kind regards from the NFDI4Chem TIB team.

batchelorc commented 2 years ago

This all looks good to me!

hujo91 commented 2 years ago

Thank you very much for the positive feedback. Then the PR can be accepted, right?

batchelorc commented 2 years ago

Accepted now. Thought I had already. Must be the heat.