rscada / libmbus

Meter-bus library and utility programs
http://www.rscada.se/libmbus
BSD 3-Clause "New" or "Revised" License
217 stars 137 forks source link

Validation of manufacturer id #114

Open krystiankaluzny opened 7 years ago

krystiankaluzny commented 7 years ago

According to comment in mbus/mbus-protocol.c:50 I think that _mbus_manufacturerid(char *manufacturer) function should check generated id in the following way: (0x0421 >= id && id <= 0x6b5a) ? id : 0 Now a ternary operator condition use two less than or equal symbols instead of one.