rscada / libmbus

Meter-bus library and utility programs
http://www.rscada.se/libmbus
BSD 3-Clause "New" or "Revised" License
217 stars 137 forks source link

Beautify tabs and spaces #72

Closed schnurksel closed 9 years ago

schnurksel commented 10 years ago

Beautify: replace tabs with spaces and remove trailing spaces I'm not very common with the libmbus source code, but I think I learned from early commits that tabs and trailing spaces are not welcome within the source. So replaced the tabs and removes trailing spaces. No functional impact.

schnurksel commented 10 years ago

Does the meter type based on the id and not version?

Yes, i add a part of the manual of the both meters (ALE & AWD), where this fact is documented: ale

schnurksel commented 10 years ago

@lategoodbye

If you can provide a single hex dump for each of the meters it would be perfect.

I will generate hex dumps for the meters next time when I have access to the devices (right now I have not).

schnurksel commented 10 years ago

As a rule of thumb i used the product name from the manufacturer with the same

I understood your approach. You may just merge the new meter names (if you want) and skip the few lines with alternative brands. I self will keep the brand names in my personal repository, because we have users that are irritated, when they are lokking at their meter with the name ABC, but the software detects a meter XYZ. They may assume the meter has been wrong identified and start a support request.

lategoodbye commented 10 years ago

I understood your approach. You may just merge the new meter names (if you want) and skip the few lines with alternative brands. I self will keep the brand names in my personal repository, because we have users that are irritated, when they are lokking at their meter with the name ABC, but the software detects a meter XYZ. They may assume the meter has been wrong identified and start a support request.

I understand but this implementation was primarly intended to support M-Bus experienced users. It is not 100% accurate. So please keep this in mind.