search

rscarrera27 / Sanic-JWT-Extended

⚡️An open source Sanic extension that provides "extended" JWT support
https://sanic-jwt-extended.seonghyeon.dev
MIT License
35 stars 8 forks source link

ModuleNotFoundError when installing with requirements.txt #6

Closed sjquant closed 5 years ago

sjquant commented 5 years ago

Issue This module has dependency on sanic, jwt, etc. But, when i installing this package with requirements.txt (which has sanic in it) in clean virtual environment with no packages, it raises ModuleNotFoundError (sanic, and jwt either).

Proposed Solution I think it's because __version__ import part in setup.py. When importing __version__, it also tries JWT Manager (which imports sanic and jwt). I came up with two solutions.

  1. writes versions directly in requirements.txt
  2. read __version__ with f.read() like sanic I also uploaded picture of that part that part in Sanic below.

image

sjquant commented 5 years ago

@NovemberOscar

rscarrera27 commented 5 years ago

Thanks for report :)

Can you fix and PR? I think you can fix this.

Unfortuenatly if you can't, I'll fix this by tomorrow. 😗

On Sat, Jun 29, 2019, 15:15 Seonu Jang notifications@github.com wrote:

@NovemberOscar https://github.com/NovemberOscar

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NovemberOscar/Sanic-JWT-Extended/issues/6?email_source=notifications&email_token=AE54WWJOUQUB5O4X5WWTLCDP434WRA5CNFSM4H4JW7LKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY3SROI#issuecomment-506931385, or mute the thread https://github.com/notifications/unsubscribe-auth/AE54WWLDOXJC6IEPVT4UZE3P434WRANCNFSM4H4JW7LA .

sjquant commented 5 years ago

@NovemberOscar Okay. I sent PR #7