rschilling / websmsdroid

Automatically exported from code.google.com/p/websmsdroid
0 stars 0 forks source link

Receivers ID first digit was removed befor it reached the fishtext server therefor sms failled #580

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. typing reciever ID 31622xxxxxx
2.
3.

What is the expected output? What do you see instead?
Expecting SMS to reach the receiving ID 31622xxxxxx
Instead no sms reaches the receiving ID 31622xxxxxx
Online Account Shows me the Receiving ID 1622xxxxxx
I tryed some more times and always this ID 31622xxxxxx
was changed into ID 1622xxxxxx.

Wenn sending it from the online fishtext account itself the ID 31622xxxxxx 
stays the same and the sms is received at the ID as requested.

What version of the product are you using? On what operating system?
Fishtext Connector 1.5.1
Android 2.3.3

Original issue reported on code.google.com by abcp...@googlemail.com on 11 Sep 2011 at 11:34

GoogleCodeExporter commented 9 years ago
I haven't been able to reproduce this issue. If I enter "31622xxxxxx" I get 
+YY31622xxxxxx, where YY is the default international code as set in the main 
application preferences. If I enter "+31622xxxxxx" then that exact number is 
used intact.

Can you tell me whether the number is entered in the international format (e.g. 
+31622xxxxxx) or exactly as you entered above? In fact, can you provide the 
exact text that appeared in the recipient input field (e.g. "Fintan 
<+31622xxxxxx>")

The fishtext connector uses the standard websms utility functions for 
extracting the sender number from the input as well as converting it to the 
international format, so I suspect the problem does not lie there.

Would you be able to send the application logs from a run-through of trying to 
send to this number?

Original comment by fint...@gmail.com on 12 Sep 2011 at 9:49

GoogleCodeExporter commented 9 years ago

Original comment by fint...@gmail.com on 12 Sep 2011 at 9:49

GoogleCodeExporter commented 9 years ago
I am waiting on Fishtext to Add my Paypall payment i do not have any credits 
there at this moment because of that:)

In the "Default international prefix" was "+" the only key put in.
Perhaps this is the error?

Thanks for your quick reply on this.

Original comment by abcp...@googlemail.com on 12 Sep 2011 at 10:21

GoogleCodeExporter commented 9 years ago
I don't think having "+" as your default prefix should cause a problem. 
However, if you set your default international prefix to be "" (i.e. empty 
string), this will cause a problem. We convert the number to international 
format using the websms functions, which should return a number starting '+'. 
If the default international prefix is "", then we will be erroneously removing 
the first character of the number, as is happening for you. I was able to 
recreate the issue by setting the default international prefix to "".

Felix: I've cc'd you as this concerns the Utils.national2international function 
as well as the main preference for default international prefix.

Setting the default international prefix to an invalid value should not be 
allowed. In this instance if the value is "" then one cannot assume that the 
response from Utils.national2international starts with a '+'.

If you enter an invalid prefix you get a warning, but I think it should be an 
error instead as otherwise you can run into trouble later, as we are seeing 
here.

Original comment by fint...@gmail.com on 12 Sep 2011 at 10:48

GoogleCodeExporter commented 9 years ago
You are wright!, I had ""  set as prefix because i didnt put anything in and 
changed it later on to "+" but my credits run out..
So i though i tested it but unfortunatly i didnt test it with the "+" prefix.

But i am glad that i could help finding this "" prefix problem.

Thanks

Original comment by abcp...@googlemail.com on 12 Sep 2011 at 10:59

GoogleCodeExporter commented 9 years ago
I am still waiting for Fishtext to add my paypall payment:(
So testing with "+" prefix isnt done yet!

Original comment by abcp...@googlemail.com on 12 Sep 2011 at 11:01

GoogleCodeExporter commented 9 years ago
Just tested with Default Prefix "" causing delete first digit from Reciever ID 
as described in the first post.
Default Prefix "+" Just works fine and transmits the receiver ID as put in.

Thanks:)

Original comment by abcp...@googlemail.com on 12 Sep 2011 at 10:29

GoogleCodeExporter commented 9 years ago
Closing this issue as there is no problem when a correct default prefix is used.

Original comment by fint...@gmail.com on 14 Sep 2011 at 10:13

GoogleCodeExporter commented 9 years ago
the next version will prevent you from setting '' or '+'.
and it will set your prefix automatically, as soon as a number is set. or
for first installers if a sim card with a valid number is available.

Original comment by f...@ub0r.de on 14 Sep 2011 at 4:53