search

rschmukler / powerdrill

Mandrill, with Power
55 stars 9 forks source link

Fix chaining with duplicate emails #11

Closed MuzzleFork closed 9 years ago

MuzzleFork commented 9 years ago

Hey Ryan,

I came across a problem where my code failed when duplicate recipients were added to the message. Specifically the method chaining broke because .to() returned nothing, but normally returns the message.

I also noticed that the duplicated address wasn't added, despite the warning that it would be, but would have the first attempt's merge variables.

I've rearranged those few lines to fix them both and modified the unit test to ensure that the address got added again.

Let me know if this is acceptable and if so, when you add it to NPM so I can kick off a new deployment of my app.

Thanks,

Lucas.

rschmukler commented 9 years ago

Thanks Lucas! Published on NPM as powerdrill@0.2.17

MuzzleFork commented 9 years ago

Sweet. Thanks buddy.

Thanks,

Lucas.

On 20 Aug 2015, at 12:13 AM, Ryan Schmukler notifications@github.com wrote:

Thanks Lucas! Published on NPM as powerdrill@0.2.17

— Reply to this email directly or view it on GitHub.