module.pkg undefined throws Cannot read properties of undefined (reading 'dependencies')

[VandeurenGlenn]

have multiple varint deps, only the first one works as expected, after that all fail to find the dist-tag

[rschristian]

have multiple varint deps, only the first one works as expected

I have absolutely no idea what this means.

Please provide your inputs.

[VandeurenGlenn]

@rschristian Cannot read properties of undefined (reading 'dependencies') is thrown when I upload https://github.com/leofcoin/monorepo/blob/main/packages/chain/package.json

As you can see from the screenshot below it finds the correct dist-tag the first time, but after that doesn't

[VandeurenGlenn]

Think I know why, the dependency is a github dependency

the 'g' from github is missing

[VandeurenGlenn]

But on the other side, the created key will always be the same but yet never is a cached module used.

[rschristian]

But on the other side, the created key will always be the same but yet never is a cached module used.

I don't know why you think this is, the cache is very clearly used. As it looks like you've inserted your own logs, they're likely set up incorrectly.

Think I know why, the dependency is a github dependency

GitHub deps will not be supported.

[VandeurenGlenn]

@rschristian Indeed, cache works, would have been weird if it really doesn't because a simple map.

GitHub deps will not be supported.

Oh damn, why is that? I just added initial support https://github.com/rschristian/deptree/compare/master...VandeurenGlenn:deptree:master

[rschristian]

Because GitHub dependencies are a really, really bad idea with the current Node package managers. They are not at all equipped to use GH dependencies safely and the use should be heavily discouraged (if not removed outright).

You're referencing code that could change at any point in time without any guarantees of owner. Don't do it.

[VandeurenGlenn]

Aha, I see, makes sense!