search

rschroll / beru

The Basic Epub Reader for Ubuntu
http://rschroll.github.io/beru/
GNU General Public License v3.0
24 stars 12 forks source link

Rotating the screen confuses Beru layout #32

Open stuartlangridge opened 10 years ago

stuartlangridge commented 10 years ago

If I rotate the phone so that it's landscape, and then go back to portrait, Beru's layout of a book often gets confused, displaying larger than the screen and weirdly misaligned. It's not currently possible to lock orientation either on the phone itself or in Beru, so I can't avoid occasionally doing this; I have to force-quit Beru and restart it to fix it.

rschroll commented 10 years ago

Does going back to the book list and selecting the book again fix things or not? You say that this happens "often". As a guess, is it more apt to happen when you switch quickly than when you switch slowly?

stuartlangridge commented 10 years ago

Going back to the book list and then back into the book does fix things.

It does not happen every time, and I'm finding it hard to make it happen on command, so I don't know about speed.

On Tuesday, 25 February 2014, Robert Schroll notifications@github.com wrote:

Does going back to the book list and selecting the book again fix things or not? You say that this happens "often". As a guess, is it more apt to happen when you switch quickly than when you switch slowly?

— Reply to this email directly or view it on GitHubhttps://github.com/rschroll/beru/issues/32#issuecomment-36041074 .

New Year's Day -- everything is in blossom! I feel about average. -- Kobayashi Issa

rschroll commented 10 years ago

What's going on is that Monocle, the library responsible for laying out the book as pages, is getting confused about the screen size. I've seen the same thing happen when I resize the window. I suspect resizes in a quick sequence will be more likely to trigger problems, since it might make Monocle start a layout before it's finished with the last one.

I'll update to the latest version of Monocle, but I don't see any changes that will obviously fix this. We may be able to add a sanity check somewhere to tell Monocle that it's screwed up, and needs to go layout everything again.

stuartlangridge commented 10 years ago

suggestion: on rotate, destroy and recreate, or explicitly size, the webkit widget? Or something? Question mark?

Obviously this stuff ought to be handled better, but dealing with resizes in a laid out thing is hard :)

On Tue, Feb 25, 2014 at 11:00 PM, Robert Schroll notifications@github.comwrote:

What's going on is that Monocle, the library responsible for laying out the book as pages, is getting confused about the screen size. I've seen the same thing happen when I resize the window. I suspect resizes in a quick sequence will be more likely to trigger problems, since it might make Monocle start a layout before it's finished with the last one.

I'll update to the latest version of Monocle, but I don't see any changes that will obviously fix this. We may be able to add a sanity check somewhere to tell Monocle that it's screwed up, and needs to go layout everything again.

— Reply to this email directly or view it on GitHubhttps://github.com/rschroll/beru/issues/32#issuecomment-36069856 .

New Year's Day -- everything is in blossom! I feel about average. -- Kobayashi Issa