search

rschroll / beru

The Basic Epub Reader for Ubuntu
http://rschroll.github.io/beru/
GNU General Public License v3.0
25 stars 12 forks source link

Figure out what to do about new header styles #49

Closed rschroll closed 10 years ago

rschroll commented 10 years ago

There's a new header style that moves the toolbar items up to the header. It'd be nice to use this on most pages, but it's not going to work on the Book Page, where there's no header. Is it okay to have different styles on different pages? Is that even possible?

rschroll commented 10 years ago

From Michael Hall: There's no plan to make full screen Pages work with the new header. We have to provide the back button ourselves in this case. We may be able to use the toolbar on the BookPage and the new header on the new pages by toggling the property on the MainView in some event handler.

rschroll commented 10 years ago

I've got this basically working in a branch, and it does look better. There are two bugs in the toolkit that are tripping me up, however. Disabled actions aren't faded and popups don't point to the right place.