Open rhersel opened 9 years ago
This is likely due to a problem with the epub file you're viewing.
Some epubs set the text color of every paragraph individually, instead
of using a global CSS rule. The technique Beru uses to change the text
color doesn't override those individual rules. I've hesitated in
trying to up the priority of Beru's CSS to override these, because
a) Individual rules can always be more specific than global ones, so I
can't always win.
b) There are legitimate reasons to change the text color of some
elements (for example, to highlight a bit of text), and I don't want to
trample these.
I see (at least) two possibilities worth pursuing: 1) Add a "Force styles" option that would escalate the applied styles. It wouldn't solve (a), but it would at least let the user choose when to risk (b). 2) Remove rules that set the text color to black. There's a slight risk of harming legitimate uses here (black text inside red text inside black text?), but I'd be surprised to see such cases in the wild.
I tested it with several other eBooks and can confirm your suspicion. It is not a big issues for me because the books are readable anyway. I will close this one. Thank you.
I'm going to leave this issue open for now. It's a somewhat common problem that'd be nice to solve. It may not happen soon, though.
When I switch to any of the two dark backgrounds (either 'light on texture' or 'white on black') nothing is readable at all because Beru shows dark text on black background. See attached screenshot.