This follows on from the work of commit 5e84ae0506 (RT #120038). Things
seemed to be working fine without this change, but I've since run into
intermittent failures (suggesting memory corruption), which this further
change appears to fix. Again, it's refraining from mucking around directly
with environ, which seems like a Good Thing according to MSDN's _putenv()
documentation. The same manpage also says that _putenv() with an empty
"value" is the correct way to delete an environment variable. I've searched
for any other uses of environ and don't see any more, so hopefully this is
it this time!
This follows on from the work of commit 5e84ae0506 (RT #120038). Things seemed to be working fine without this change, but I've since run into intermittent failures (suggesting memory corruption), which this further change appears to fix. Again, it's refraining from mucking around directly with environ, which seems like a Good Thing according to MSDN's _putenv() documentation. The same manpage also says that _putenv() with an empty "value" is the correct way to delete an environment variable. I've searched for any other uses of environ and don't see any more, so hopefully this is it this time!