Fix Makefile target order for parallel build

rschupp / PAR-Packer

(perl) Generate stand-alone executables, perl scripts and PAR files https://metacpan.org/pod/PAR::Packer

Other

48 stars 13 forks source link

Fix Makefile target order for parallel build #8

Closed nfetisov closed 6 years ago

nfetisov commented 6 years ago

Replace MY:postamble() with MY::depend() (fix: #7)

rschupp commented 6 years ago

I think your analysis in #7 is correct, however I don't like this fix. It relies on a certain order of sections in the Makefile generated by ExtUtils::MakeMaker that could change. Besides: if you override a method like depend() you should respect its interface - e.g. what would happen if someone added a "depend" argument to the call of WriteMakeFile(). Fixed in 04a133b by using adding a .NOTPARALLEL target.