Crash in Rocksmith 2012 just before tuning the guitar with package created by Toolkit v2.3

[Chlipouni]

I have this issue with all of my customs.

Toolkit v2.3 :

• Open a 2012 dlc.xml file with Toolkit v2.3
• Generate the package (with no change)
• Deploy the new package in RS2012
• Crash just before the tuning step

Toolkit v1.4 :

• Open the original dlc.xml file with Toolkit v1.4
• Generate the package (with no change)
• Deploy the package in RS2012
• Works fine

Thanks

[L0FKA]

it would me great if you diff 1.4 dat and 2.3 dat

I've resolved rough issues with exceptions to allow produce 2012 dlc but cant validate its worked, thanks :)

[Chlipouni]

Here are the links for downloading the two .dat files :

http://www.mediafire.com/download/09a04etfpb1xqlp/Accept%20-%20Balls%20To%20The%20Wall%20-%20TK%20v1.4.dat

http://www.mediafire.com/download/fo4c0n5fdchq328/Accept%20-%20Balls%20To%20The%20Wall%20-%20TK%20v2.3_p.dat

Thanks

2014/1/10 L0FKA notifications@github.com

it would me great if you diff 1.4 dat and 2.3 dat

I've resolved rough issues with exceptions to allow produce 2012 dlc but cant validate its worked, thanks :)

— Reply to this email directly or view it on GitHubhttps://github.com/rscustom/rocksmith-custom-song-toolkit/issues/107#issuecomment-32019651 .

[fabianosan]

Crash before or after tuning step? Just confirm, because if crash after probably is a problem with .bnk if crash before maybe is a problem with .SNG.

Can you post here the title of your toolkit with exactly version?

[Chlipouni]

Crash is before the tuning step.

The Toolkit v2.3 release is : v2.3.0.0-24da9151 beta The Toolkit v1.4 release is : v1.4.0.0 beta

[Chlipouni]

Sorry for the "closed" status, it was a mistake ...

[L0FKA]

In: song.xblock

become 9

song.manifest "RelativeDifficulty": 7, become 9 different precision on floating numbers in manifest "IsSolo": false become true if its solo(just working bug fix) in attributes added "Prebends", hope RS ignore that like "Vibrato" "Prebends": false, become true "RelativeDifficulty": 1, become 0

sng are different(in new tkit missing some bytes, but its not encrypted, thats good

[fabianosan]

Forget about manifest, if have a problem with manifest the song don't appear in song list or just don't show a specific info in song list, the only thing to see in manifest is tuning info.

All the differences in manifest you related are from new fixes of the new toolkit (RelativeDifficulty) is not manually defined anymore, is obtained from song xml, IsSolo now is setup in toolkit, the 1.4 doesn't setup solo sections, is the same as Prebends, because all techniques are now automatically obtained from song xml, I did this fixes, I believe that is not the problem.

Here is the path of the problem:

1. Check tuning data in manifest (I checked and is the same, so is not the problem);
2. Soundbank file (.bnk);
3. Sound game file (.sng)

@Maveth Maybe you can help us with .SNG file? @snakez Maybe you can help us with .BNK file?

All about RS1 songs.

Me and @L0FKA verifying some other things.

We need to put RS1 customs working again on lastest toolkit.

[fabianosan]

@Chlipouni Can you download old releases like 2.2, 2.1 to see if it work?

https://github.com/rscustom/rocksmith-custom-song-toolkit/releases

[Chlipouni]

Yes, I can do this ...

[Chlipouni]

I don't have the 2.1 and 2.2 releases on my computer. Where can I download these old builds ?

[L0FKA]

2.2 -> https://github.com/rscustom/rocksmith-custom-song-toolkit/releases/download/2.2.0.0/RocksmithCustomSongToolkit-v2.2.0.0.zip

2.2.2.1 -> https://github.com/rscustom/rocksmith-custom-song-toolkit/releases/download/2.2.2.1/RocksmithCustomSongToolkit-2.2.2.1-3dbc716ff7cf.zip

[L0FKA]

But i'm sure its about SNG, we changed some field types for RS1 too, so it could be there.

[Chlipouni]

Toolkit v2.2.0.0 :

• If I use the dlc.xml from release 1.4, I have an error about the "E Standard" value when I generate the package
• If I use the dlc.xml from release 2.3, it generates the package, but only the "psarc" file (no "dat" file)

Toolkit v2.2.2.1 :

• Crash before tuning in RS2012

[L0FKA]

so 2.2.0.0 got no problems?

[Chlipouni]

I can't generate the "dat" file with the release v2.2.0.0 for other reasons, so I can't test the package ...

[fabianosan]

Just rename to .dat, it's only wrong extension.

[Chlipouni]

Crash before tuning with the package generated by Toolkit v2.2.0.0.

[Chlipouni]

Yesterday, I saw that "ArdGuitar" has released a new CDLC for RS2012 ("Green Day - Nice Guys Finish Last").

I downloaded it and try this :

• Test the CDLC in RS2012 : works fine
• Unpack the dat file with TK v2.3
• Pack again the CDLC without update SNG : works fine
• Pack the CDLC with update SNG : crash before tuning step

Hope that helps

[fabianosan]

Yep, you confirmed the problem. Thanks, we need to track the change that broke the rs1 sng now.

[Maveth]

ill take a look when i get home tonight, if you havent already fixed it. i was just going to suggest testing it like that.

[Maveth]

do have the dlc, xml stuff handy? for the .dat that fails with new toolkit, but works with 1.4?

[Maveth]

i think i tracked it down using the xml2sng creator tab, i get a diff in the sngs, in the following commit c61c32be7f86908689b8c7a34f6bb40ea7aba4ce

there are a number of changes to the data types, its looks like it was used to base the initial 2014sng format off of, but wasnt reset back to normal. some of it might be ok, but not all of it... looking at the raw sng in hexeditor, its definitely the data types, byte vrs int.. stuff like that.. because all the data is there, its just not right sizes.

ill see what i can do. i dunno that changing it back to original, might cause some other issues, but ill see.

[L0FKA]

Some of sng values are changed, but it required by RS2014, so if you change one back for RS2012 - override for RS2014. or find what is wrong...

[Maveth]

i thought there are 2 processes, 1 for 2014, using song2014,cs and one for 2012 using song.cs it looks like song was copied to song2014, but it was changed before being copied? i dunno yet. but thats where it breaks.

[L0FKA]

its used some fields from RS1, so it was changed, you can compare XML\song.cs from 1.4 to last beta, and find what is wrong..

also my hsl not equals rs1 original sng what can be wrong?

[Maveth]

i dunno why its using the XML\song.cs for 2014 when there is a XML\song2014.cs, that doesnt make sense to me. if i try and change it back to what it used to be then i get compile errors for 2014filewriter? something isnt right there.

[fabianosan]

Make sense because is a object oriented language that uses inheritance. Basically all fields in song.cs are used in song2014 with only new fields.

If changes it's necessary, just create new object with new values and set song2014 variable to use this object and not inheritance.

If need create all new objects for 2014 we need to create a new RocksmithToolkitLib for 2014, it that's not make sense to me.

[Maveth]

i guess so, my old ways die hard, i just about got it though. i might duplicate a few more than HAVE to be. but that shouldnt matter

[Maveth]

i can get rs2012 working again,but getting errors for 2014 {"The best overloaded method match for 'RocksmithToolkitLib.DLCPackage.Manifest.ManifestFunctions.GetNoteCount(float, float, System.Collections.Generic.ICollection)' has some invalid arguments"}

[Maveth]

finally got sng, to match 1:1 for rs2012, to toolkit 1.4, also matched to 1:1 for rs2014 vs 2.3 toolkit. but now every package i make crashes the game??? i reverted my changes on my system and it still does it. you guys change something else in the meantime?

[Maveth]

yes, i revert to a week ago, and apply my changes and its ok. so something else done has broken the code. might be if showlights needs the original xml loaded again? dunno i dunno what it is. somewhere within the last week it starts crashing. im too tired to figure out what

[Chlipouni]

Thanks a lot for the quick resolution