rscustom / rocksmith-custom-song-toolkit

Custom song toolkit for Rocksmith and Rocksmith 2014
http://www.rscustom.net/
343 stars 80 forks source link

Arrangements sometimes not working after packaging #112

Closed MadMaxxx closed 10 years ago

MadMaxxx commented 10 years ago

This is pretty much an old issue but it does still exist.

Basically sometimes some arrangements dont work in the game, they get stuck in an endless loop after hitting start before the tuner, sometimes even after the tuner is passed.

After generating the .psarc again it works but it could be that all arrangement work or even a different arrangement is effected from the bug. It would be quite annoying to always check all arrangements after generating the package.

For example: Rhythm is working Lead is working Bass not working

its not the whole package that is not working but sometimes only one of the arrangements.

It would be nice if we can track it down.

L0FKA commented 10 years ago

We need to catch this bug, its could be abou DSA in SNG files or about tones or any other thing, it would be nice if you collect all psacs that cause this issue and compare them unpacked or attach here and I'll compare it

MadMaxxx commented 10 years ago

i dont have at the moment one but a few days ago, sadly i deleted it. If we ask in the forum im sure that someone will post one fast because i have seen also other custom creators effected from this.

its quite random to get the bug.

fabianosan commented 10 years ago

I have this problem too. It's started after otaznik added sng cache on sng generation, maybe have a problem with this feature or no, need to investigate.

Maveth commented 10 years ago

i have noticed it for a very long time as well, im not sure when it started. i keep meaning to set a file aside when it fails, so i can do a compare...

L0FKA commented 10 years ago

BTW, repack with update SNG will solve the problem...

fabianosan commented 10 years ago

So it's confirm that the problem really is the sng.

We need to fix this problem.

MadMaxxx commented 10 years ago

To answer Maveth, i think that the bug was already in the first public beta. I remember that in one of the first customs someone already wrote about it.

fabianosan commented 10 years ago

MadMaxx,

We need you help, when the problem occurs again, save problematic package, regenerate again to fix problem, and send the two packages to us (package with issue and package that works).

Thanks!

MadMaxxx commented 10 years ago

ok but i think that we can find the bug faster if we ask in the forum if someone with a broken song can post both files. Its been now more then a week since i had the issue.

fabianosan commented 10 years ago

@rockfirstlast Here is one that freezes after tuning: http://www.sendspace.com/file/lekgwr

Here is the same custom repacked and working: http://www.sendspace.com/file/ngcnm8

@rockfirstlast,

What's the arrangement that you got problem? I identify a little difference in bass arrangement (first bass arrangement, because have two).

Lead, Bass2 and Vocals are similar and I believe that have no problem.

Wait your answer.

fabianosan commented 10 years ago

More info:

@rockfirstlast When playing in LEARN A SONG mode: The tuning screen works well The fretboard appears The amps drop onto the screen and the tone changes The song never starts. The same happens for Lead, Bass, and Bass2. Score Attack Mode works well without any problems.

TimeIsFading commented 10 years ago

Yeah fabianosan, I've noticed when this happens to my customs, it will still work in Score Attack Mode even though the song never starts after tuning. Should be a clue hopefully for whats wrong.

L0FKA commented 10 years ago

I think I know what is problem with this, when you save template with SNG file non empty - we will got recreated SNG anyway cause previous was deleted automatically, well I got no problems if my sng field are empty, need to add workaround for this while dlc packs

MadMaxxx commented 10 years ago

Well it doesnt look like its fixed because i had today a return of the bug

i used 336f6691f98a

L0FKA commented 10 years ago

But I got 50% less this kind of bug, so do you saved the template? before?after?(cdlc generation) or not saved at all?

Plum said that he catched bug again, but he used old(release) version, but you got lastest...

only thing that could happened because of: Encryption-related problems(sng), maybe we got additional place where bypass won't work..

Just catched this bug with last toolkit =\

MadMaxxx commented 10 years ago

I accidently deleted the not working psarc.

I usually always save the template before generating the psarc.

fabianosan commented 10 years ago

@otaznik, are you tested your fix? Really solved this issue? If yes we can merge your changes to main repository.

L0FKA commented 10 years ago

Its ok for me just have no issue with this, it works anyway so don't hesitate to merge i think its correct.