search

rscustom / rocksmith-custom-song-toolkit

Custom song toolkit for Rocksmith and Rocksmith 2014
http://www.rscustom.net/
343 stars 80 forks source link

XBox360 / PS3 custom crashes after tuning (when start playing) #16

Closed fabianosan closed 10 years ago

fabianosan commented 10 years ago

We are so close, the game loads the song, gets to tuning and the I crash (from Acid Xbox tester) and (Redeyed PS3 tester).

fabianosan commented 10 years ago

Otaznik, can you search the problem? Maybe check the Big Endian writer on Sng2014FileWriter?

If consoles have no signature check on SNG file, so have any problem with SNG Writer...

otaznik commented 10 years ago

What is wrong with it? Can you send me the file which is presumably wrong?

You can try to replace all SNGs with official to test but I think there might be a problem with BNKs, they are not working 100% correctly on PC either (#13).

fabianosan commented 10 years ago

Acid made new tests. Probably the vocals that crashes the song in console.

Acid said: Well we have slightly better news, the customs are working... kinda. Here's a few images of Serve the Servants by Nirvana on Xbox360. Maybe you know what's causing the strange visual issues, cause I have no idea. lol

I'm almost certain the vocals are what crashes it. I first made my custom without them, then put them in for another test and it crashed this time.

p4rjv4l bxs2zqb r9xzikm

otaznik commented 10 years ago

Well, he needs to try with custom with official vocals to confirm. Also these inlined images are annoying and totally unrelated.

fabianosan commented 10 years ago

He tested two customs, one with vocals and one without vocals. The song without vocals did works fine.

About the images, is only to show that custom is working on XBox, and he have some problems in chart, but is another topic.

otaznik commented 10 years ago

I asked to test official vocals, no vocals does not prove anything. I need one vocals which work and one which do not.

fabianosan commented 10 years ago

Any vocals from official xbox custom works. I'll send a link by mail to you.

fabianosan commented 10 years ago

Here is the files that you need: https://dl.dropboxusercontent.com/u/35863200/vocals_sng_all_platforms.7z

otaznik commented 10 years ago

Both files are correct big endian vocals, did you actually try to use those official vocals in a custom like I asked?

fabianosan commented 10 years ago

I have no modded XBox, I'll ask to Acid.

fabianosan commented 10 years ago

We have only one vocals in resource (PC version), I'm right? And when you read the symbols in vocals_sng stored in resources, in make it normal, no endianess dependent? I'm right?

Have no problem with it?

L0FKA commented 10 years ago

No matter if things only in endianness - toolkit just write it in chosen one, but could be errs if structure wrong, but its correct, isn't?

otaznik commented 10 years ago

@fabianosan if there were problems with endiannes, guitar charts would not work either.

fabianosan commented 10 years ago

But we sure that the SymbolsHeader, SymbolsTexture, SymbolDefinition have no difference in both platforms?

otaznik commented 10 years ago

We don't understand vocal structures completely but it's correctly parsed. I have found one difference that might be significant, on consoles FontPathLength is zero despite path being there. I can modify SNG file for you so you can try this.

otaznik commented 10 years ago

I came across something weird on PC. I tried to modify template (change DLC name, tone volume) and it refused to start in RS (stopped at the wall or didn't start rolling note highway, it didn't crash but it's similar to this issue). I tried to change it back and forth and nothing seemed to fix it, only restarting RS once or twice without changing anything in the package.

It is very strange because I don't know about any place where RS saves this kind of information. Anyway, when something does not work, I recommend trying it a few times without changing anything (I already seen two crashes in a row on official DLC when I started fresh game, so RS is not really rock solid).

Acid6D94 commented 10 years ago

I tested Aerials by System of a Down that Fabiano sent me and it got past the tuning without the vocal chart, however it froze before getting to the guitar chart. My assumption for this is that something with certain techniques. My chart for Serve the Servants has bends and slides, it works fine. I assume that one of the techniques are muted chords because my chart for Lounge Act has no other techniques except muted chords and it freezes. I will do further testing to make sure this is the issue.

I'm about to do a test to see if an official vocal chart packaged into a custom will play.

Acid6D94 commented 10 years ago

I can confirm that an official vocals sng works with the customs.

http://i.imgur.com/YwkLWhc.png

Acid6D94 commented 10 years ago

I took out the muted chord notes in Lounge Act, it loaded and played. It still had the graphical issues though.

To be more specific on what notes i'm referring to, they are the palm mutes with all x's not the palm muted chords that have notes with them. I haven't tested those yet.

otaznik commented 10 years ago

I will try to change FontPathLength to zero on consoles. If that doesn't help we will need to know what the unknown fields mean.

otaznik commented 10 years ago

@Acid6D94 you can try again now.

Acid6D94 commented 10 years ago

We no longer crash with vocals in the package, but now we have black bars with no lyrics, they scroll through as if the lyrics were there though.

http://i.imgur.com/5qBNzey.png

(I'll be gone pretty much all day today for Thanksgiving stuff with the family, so anything that needs testing, I'll do later tonight when I get home)

otaznik commented 10 years ago

I'll open a new ticket as that's different issue. I would expect something to happen with undefined Fontpath, guess that's it. There has to be something else important for consoles.