search

rscustom / rocksmith-custom-song-toolkit

Custom song toolkit for Rocksmith and Rocksmith 2014
http://www.rscustom.net/
343 stars 80 forks source link

Problems when converting from PC to Mac #207

Closed vberry closed 8 years ago

vberry commented 9 years ago

Hi developpers, on one song over 5 or 6 there is a problem in converting an RS song (CDLC) from PC to Mac. Usually the application gets stuck (for instance with the song U2_One_Live_v1_p.psarc), but this time I got an error message asking to send you the log (which I found). This was on the french song 00 - Louise_Attaque_Jtemmène_au_vent_v1.3_p.psarc, see below the log. Thanks

RocksmithToolkitLib Void InflateEntry(RocksmithToolkitLib.PSARC.Entry, RocksmithToolkitLib.PSARC.BigEndianBinaryReader, UInt32[], UInt32, System.IO.Stream) Exception caught:

removed change log, due it's useless

L0FKA commented 9 years ago

Sorry for long delay, but it seems that you have outdated Toolkit, we've fixed this kind of error in past days, sorry that autoupdater is disabled for MACs, you can run it manually or install a fresh copy of the toolkit from our main page ;)

vberry commented 9 years ago

No, I think it's not the problem: I've updated with a quite recent version already: I'm running V 2.6.1.0-84a042f6 (extract from the "about" box in the tool).

L0FKA commented 9 years ago

All should be fine, I'll test with Linux, surely all'll be fine too, but have you this for all the psarc's? or just for thees one?

All fine at Windows, so OS X label set

vberry commented 9 years ago

Ok, I found a newer version of RSInjector.app on http://www.rscustom.net (854ko dating from May, 29, 2014):

Thanks for testing under linux and telling me if you have issues also there.

hajdbo commented 9 years ago

I found the problem with Niagara song J'ai vu... It's a problem with the converter which uses FixShowlights() which breaks the working showlights and makes the song unplayable on Mac. Manual fix: Unpack the PC package and unpack the Mac package; then overwrite the Mac showlights file with the working PC showlights file. Then repack the Mac package. I will open a new issue about this problem.

hajdbo commented 9 years ago

I converted U2 One live, Niagara J'ai Vu, Louise Attaque Viens Jtemmene au vent with the most recent build. All converted with no toolkit errror. U2 and Louise Attaque played fine in Rocksmith 2014.

However, "Niagara J'ai Vu" doesn't display the note highway and the game hangs. I remember having a playable version a few days ago; I'll try and see the differences. Since this is not a showlights problem anymore, I guess it might be related to the single quote.

vberry commented 9 years ago

I converted U2 One live, Niagara J'ai Vu, Louise Attaque Viens Jtemmene au vent with the most recent build.

Did you post new versions for these songs on custom forge? That would be great if the problem is fixed!

Niagara is really a fine song, hope you'll be able to fix this single quote problem.

Thanks for your help in this.

hajdbo commented 9 years ago

Very interesting, we have a regression! On Mac, build 120 (https://ci.appveyor.com/project/rscustom/rocksmith-custom-song-toolkit/build/120/artifacts ) builds a working Niagara-JaiVu when following these steps:

1- convert PC->Mac 2- unpack Mac & unpack PC 3- copy the showlights.xml from PC to Mac 4- pack the Mac directory --> working CDLC

When using the same steps (or only converting, as the newest build does not modify showlights.xml) with the latest build, game hangs.

vberry commented 9 years ago

Ok, after receiving you post I tested in parallel this afternoon:

Here are what happened:

So:

Thanks guys

hajdbo commented 9 years ago

Let's try all builds between 120 and 141, to find the problematic commit.

L0FKA commented 9 years ago

just let me know If it showlight issue of is it something sng related or..? that would be faster

hajdbo commented 9 years ago

I don't know. Build 130 works like 120. I'll try 135 next.

hajdbo commented 9 years ago

build 135 works also.

hajdbo commented 9 years ago

Build 139 works also

hajdbo commented 9 years ago

Damned. My patch to keep the showlights.xml intact breaks something else. To build a working Niagara-JaiVu, it seems we need to "first fix/break" the showlights.xml, then build the SNG and then put the original showlights.xml.

cozy1 commented 8 years ago

@hajdbo Can we close this?

L0FKA commented 8 years ago

I've fixed CDT showlights bug, so It's probably done for now..

vberry commented 8 years ago

Thanks LOFKA for your modification. I will download the new version ASAP (next week maybe), and will give feedback.

vincent

Le 25 janv. 2016 à 09:18, L0FKA notifications@github.com a écrit :

I've fixed CDT showlights bug, so It's probably done for now..

— Reply to this email directly or view it on GitHub https://github.com/rscustom/rocksmith-custom-song-toolkit/issues/207#issuecomment-174433943.

hajdbo commented 8 years ago

I confirm the showlights bug has been fixed. CDLC "Niagara - J'ai vu" and "Rod Stewart - Young Turks" were good tests; both works after converting with build 183. Great job guys.

vberry commented 8 years ago

Good to know about Niagara. I just tested Creedence Clearwater - I put a spell on you which wasn't rightly converted with the previous version, now it's ok. Thanks a lot !