rscustom / rocksmith-custom-song-toolkit

Custom song toolkit for Rocksmith and Rocksmith 2014
http://www.rscustom.net/
343 stars 80 forks source link

Make the volume labeling easier to understand #27

Closed raynebc closed 10 years ago

raynebc commented 10 years ago

Even now, the fact that the volume definitions for tone and song have opposite effects in the toolkit confuses people: http://forums.smithyanvil.com/viewtopic.php?pid=81800#p81800

If it hadn't been done already, could you label the Edit tone's and DLC Package Creator's volume fields to make the difference more obvious, ie with: "higher is louder" and "lower is louder"

aludog commented 10 years ago

I can only second that. It may seem like a minor issue, but poses a lot of trouble for first time users.

fabianosan commented 10 years ago

You're right, the big problem about this issue is because the value that you set is written in the package and the game works well with this definition without changes. To do this improvement that you want we need to do a workaround.

L0FKA commented 10 years ago

I'm changed type to float, as it is in manifests and in bnk, also @snakez, has rewritten BNKGenerator now its produce complete bnk from zero. need to test if it does change something to tones\song volume.

fabianosan commented 10 years ago

To achieve the result desired in this issue, we need to invert direction of numericUpDown control and on setup value multiply by -1

But we need to test a lot before do this change.

Maveth commented 10 years ago

is this really a bug? i would consider it an enhancement?

L0FKA commented 10 years ago

yup its does better user experience with toolkit, changed

also what does mean "SortOrder": 14.0 "SortOrder": 20.0

etc its for tones

fabianosan commented 10 years ago

Alex, you already did this enchancement? You changes works?

Maveth commented 10 years ago

no, i think just changed its tag from a bug to enhancement. no code it commited

L0FKA commented 10 years ago

About RS2 tones I guess that tab balance in tone designer can explain some aspects - for manual edit its alow +- 10 points to gain reduce guitar volume, i dunno whats wrong but even with -20 we don't use those stuff, but should there error(s) in tone manifest for songs, need to debug

Maveth commented 10 years ago

to make sure we are 100% on the same page song volume (HIGH 0 , -1,-2 , -3 ,,,, average -12, ....,-16,-17 LOWER) tone volume (LOW 0 , -1 , -2, -3, ..... average -12 .... ,-20, -21 HIGH,...-100.BLEEDING EARS) this is correct?

L0FKA commented 10 years ago

About volume again, I think its something like sin function,here image of that I mean: (its not real graphic, its just show where would + where would -) cheme

we have -12 so its become +8 in balance

L0FKA commented 10 years ago

@Maveth now i know why bass louder than guitar in rs1 even its has -12 and guitar -14 its because -12 become - +8 and -14 become +6 lol, thx RS2 we know that now!

L0FKA commented 10 years ago

I'll change default song volume to -6

fabianosan commented 10 years ago

Is good. Custom comes too loud.