search

rscustom / rocksmith-custom-song-toolkit

Custom song toolkit for Rocksmith and Rocksmith 2014
http://www.rscustom.net/
343 stars 80 forks source link

Generating DD changes volume from 0 to -12 #290

Closed iminashi closed 7 years ago

iminashi commented 7 years ago

If you generate DD on a psarc file where the song volume is set as 0.0, it will be changed to -12.0.

L0FKA commented 7 years ago

Truly a bug for me but it's made intended so it will have default value, I'll write function to get individual song and preview volume values from bnk, adding to todo list, thanks

cozy1 commented 7 years ago

@iminashi @L0FKA This is because if song volume is 0.0 then toolkit defaults to -12. https://github.com/rscustom/rocksmith-custom-song-toolkit/blob/master/RocksmithToolkitLib/DLCPackage/DLCPackageData.cs#L505 If you actually want to use volume of 0.0 then we will have to delete the toolkit default.

cozy1 commented 7 years ago

Fixed ... you can still use 0.0 as a volume, and toolkit will not change 0.0 to -12.0 anymore. https://github.com/rscustom/rocksmith-custom-song-toolkit/commit/8e59dbd5f989612e0c464104c794d44d66bfc36e

@L0FKA you can still write function for bnk if you want.

L0FKA commented 7 years ago

@cozy, I'm finishing with bnk format for RS2014, gotta draw quic read function since it's almost fixed in bnk, gimme 2 days for this :)