search

rscustom / rocksmith-custom-song-toolkit

Custom song toolkit for Rocksmith and Rocksmith 2014
http://www.rscustom.net/
340 stars 79 forks source link

Two problems with Japanese artist/title #304

Closed iminashi closed 6 years ago

iminashi commented 6 years ago

  1. The manifest attribute name should be "JapaneseArtistName" instead of "JapaneseArtist".

  2. Empty strings shouldn't be serialized. Otherwise you'll get this:

20180225150617_1

L0FKA commented 6 years ago

Like for the Fantasy Seph's about "Empty strings shouldn't be serialized. Otherwise you'll get this" you mean like whole thing or just Japanese one? right?

iminashi commented 6 years ago

When playing the game in Japanese, the game won't display a title since the Japanese title for the song is set as "". I noticed a couple of such titleless customs among the ones I downloaded recently. I didn't have a working computer for quite a while so I wasn't able to test sooner.

L0FKA commented 6 years ago

Oh, so I'll kill that empty string it was intended to mute like that actually.

AgonasiGen commented 6 years ago

Song title was displayed in Japanese, but artist name is displayed in English. Is this a bug?

iminashi commented 6 years ago

Yes, the manifest attribute name for Japanese artist is wrong. It will work once it's renamed to "JapaneseArtistName".

AgonasiGen commented 6 years ago

I see. understood. wait for it to be fixed.thank you so much.

L0FKA commented 6 years ago

Well simple rename should help anyway I don't allow toolkit to write empty japanese-fields in json fines, I'll commit changes within uhd support so feel free to report odds in "refreshed" interface :)