Closed angk500 closed 6 years ago
Issue is caused by album art. Using the 'Default' album cover makes it work. Album cover is a .bmp file. Trying with different file format next.
EDIT: Can confirm. Problem is caused by .bmp files. Other file formats work fine.
Can you open that bmp file in paint for example? could it be damaged? nvdxt should work fine with bmp format and error said something about .dds file not found so it could be something else and it really could be nvdxt issue with bmp files then. We need to investigate this.
I have tried to open this file with various programs including photoshop. It does open without any problems. It was converted with an online converter, so I was also thinking it could be corrupt. For your curiosity, this is the image I am using: https://www.dropbox.com/s/kyz5xlx7eyoudgn/a2697307231_16.bmp?dl=0
To get some troubleshooting work off your hands: I have converted another .bmp file, this time not resized. Same issue. I have tried another image, resized, same issue. I have tried to resize it with photoshop and convert it into .gif and into .png. These work perfectly fine. Seems like it is a file format problem.
Have you tried using a 512x512 jpg of that cover? bmp's can be iffy.
I did try different resolutions and file formats. So yes also 512,512 jpg. Only bmp files caused this error.
The 24-bit bmp image you are feeding the toolkit is incompatible with with the converter. Plz try a 32-bit image and let us know.
EDIT: BMP conversion is not working. We will work on a fix. Do not use .bmp files for now.
@angk500 Fixed bmp to dds image converter here: https://github.com/rscustom/rocksmith-custom-song-toolkit/commit/a81c9a7a2ce9372da06d08a930a6c162b057f57e Only 32-bit bmp images are supported by the converter. Plz try it and give feedback.
well I'd rather drop bmp support or do it in hackish way with reading bmp using gdi and saving to png or any other format before feeding it to nvdxt
In other words - please do it yourself then? I'll try to this weekend no matter what.
I'm ok with it as-is, bmp conversion works again. So if you want something different ... go for it.
I couldn't keep up with you guys, haha. So now only 32-bit bmp is supported? I have converted mine in an online converter without any possible settings for the bit depht, so I guess I won't be the only one with this error. But maybe it's possible to implement an error message with a bit more of info of this? Otherwise I guess there will be people pulling their hair out ;-)
@cozy1 Changing the nvdxt arguments broke something else and now there are ugly transparent pixels in my cover picture that weren't there before:
@iminashi Alpha channel is missing now so it's obvious that any ex-transparent pixels become solid color and has overall worse quality I'd rather change it to dxt5 since size ain't that matter here and quality may improve a bit :)
Better option is to deprecate support for bmp files and restore the original dxt1a format. @L0FKA can play with GDI support when he has time.
@iminashi Let us know if dxt1a artwork is working again.
It is indeed working again.
When generating a new package I receive an error message. 'Could not find file'
tmp folder is empty.