search

rscustom / rocksmith-custom-song-toolkit

Custom song toolkit for Rocksmith and Rocksmith 2014
http://www.rscustom.net/
343 stars 80 forks source link

Upload project to Nuget #352

Closed kortov closed 3 years ago

kortov commented 4 years ago

Hi, there is a project https://github.com/foxx1337/RocksmithToTab , which doesn't build anymore due outdated RocksmithToolkitLib.dll . I can upload it there as binary ofc, but I would like to do it the right way and to add is as a nuget package.

May be you'll add this project to nuget? As a reference you can look here https://medium.com/@wajahataliabid/github-actions-automate-nuget-package-deployment-1533b11d2be1 as there are some api keys in nuget and github, I can't do it by myself. And I can't upload my fork due missing license file #351

cozy1 commented 4 years ago

Sorry I don't work with nuget packages. That repo is using a very old version of the RocksmithToolkitLib.dll anyway which does not include the lib validation check so that repo should build/work just fine as is. Please request the author RocksmithToTab to update the library if you are still having issues.

On Tue, Jul 7, 2020 at 4:36 AM Eugene Kortov notifications@github.com wrote:

Hi, there is a project https://github.com/foxx1337/RocksmithToTab , which doesn't build anymore due outdated RocksmithToolkitLib.dll . I can upload it there as binary ofc, but I would like to do it the right way and to add is as a nuget package.

May be you'll add this project to nuget? As a reference you can look here https://medium.com/@wajahataliabid/github-actions-automate-nuget-package-deployment-1533b11d2be1

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rscustom/rocksmith-custom-song-toolkit/issues/352, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABT5MQIRDKDQPK6HZ3KJYPTR2LUABANCNFSM4OSUD45Q .

L0FKA commented 4 years ago

License for all C# is mostly MIT license but there's 3rd parties as well, but we should put rstkLib in separate repo, but that require some refactoring and additional work that may broke toolkit itself for a period of time. Also You can use toolkit as gui for cdlc2tab. as for updates it's were non important to rs2tab library we should update it, the thing works great as is already :thinking:

p.s. Hello Samara city :wave:

kortov commented 3 years ago

ok I got you, thanks, I'll close the issue