search

rsdn / CodeJam

Set of handy reusable .NET components that can simplify your daily work and save your time when you copy and paste your favorite helper methods and classes from one project to another
MIT License
258 stars 35 forks source link

Fix for targeting.props #124

Closed ig-sinicyn closed 3 years ago

ig-sinicyn commented 3 years ago

@NN--- I've updated codegen for targeting.props. I do not update <TargetFrameworks> property of real projects, however

Feel free to change target framework lists in Targeting tests as you wish.

P.S. If any questions you can contain me via igor.sinicyn@gmail.com or skype igor.sinicyn@outlook.com. I think it will be much faster than chatting in the PR:)

NN--- commented 3 years ago

For some reason test expects 4.7.2 and not 4.8 .

Failed : CodeJam.TargetingTests.TestTargeting
  Expected string length 28 but was 26. Strings differ at index 25.
  Expected: ".NETFramework,Version=v4.7.2"
  But was:  ".NETFramework,Version=v4.8"
  ------------------------------------^
   at CodeJam.TargetingTests.TestTargeting() in C:\projects\codejam\CodeJam.Main.Tests\TargetingTests.cs:line 255
NN--- commented 3 years ago

Fixed. Waiting for build.

ig-sinicyn commented 3 years ago

Fixed. Waiting for build.

Thanks!