rse-ops / docker-images

Collection of Docker image bases provided by the RSE-ops community.
https://rse-ops.github.io/docker-images/
MIT License
5 stars 8 forks source link

Try building HIP again #42

Closed davidbeckingsale closed 2 years ago

vsoch commented 2 years ago

@davidbeckingsale do we need to add the flag to allow not having a checksum?

 ==> Warning: There is no checksum on file to fetch llvm@13.0.0 safely.
==> Error: FetchError: Will not fetch llvm@13.0.0
    Add a checksum or use --no-checksum to skip this check.

/opt/spack/lib/spack/spack/package.py:1345, in do_fetch:
       1342                    tty.debug('Fetching with no checksum. {0}'
       1343                              .format(ck_msg))
       1344
  >>   1345            if not ignore_checksum:
       1346                raise FetchError("Will not fetch %s" %
       1347                                 self.spec.format('{name}{@version}'), ck_msg)
       1348
davidbeckingsale commented 2 years ago

Good question - I think LLVM 13 is new and uptodate has just found it in the spack package? I'm not sure why there wouldn't be a checksum.

vsoch commented 2 years ago

That's a good question - it does look like it's added to spack, so maybe we've hit a bug? We haven't built it before (but cool that uptodate found it!) https://github.com/rse-radiuss/docker-images/pkgs/container/clang-ubuntu-20.04/versions

vsoch commented 2 years ago

here is the line added https://github.com/spack/spack/blob/da31c7e894b4042e893d361e3c6dbbf2d38805b6/var/spack/repos/builtin/packages/llvm/package.py#L34

vsoch commented 2 years ago

Looks like the updated spack doesn't build with 16.04:

==> Bootstrapping clingo from pre-built binaries
==> Installing pkgconf-1.8.0-wrfzcxiwuxp6n35gbncfhkne3rorsypj
==> Warning: Skipping build of ncurses-6.2-m6pjkausvlwxp4hvk4qkog72bhtbpyua since pkgconf-1.8.0-wrfzcxiwuxp6n35gbncfhkne3rorsypj failed
==> Warning: Skipping build of cmake-3.20.4-d4anms4mhkpm4244d2zmzv3ityjb6hx6 since ncurses-6.2-m6pjkausvlwxp4hvk4qkog72bhtbpyua failed
==> Error: Failed to install pkgconf due to SyntaxError: invalid syntax (auth.py, line 121)
[+] /usr (external perl-5.22.1-csfqvfq5zyh7ulrfmwoxcvvgtudzzuh3)
==> Installing zlib-1.2.11-265kubw7f4z72djuxdloupfvtn7nmr3c
==> Warning: Skipping build of openssl-1.1.1l-6ag5xtyphgnay2eotbaetzctzavfr7fb since zlib-1.2.11-265kubw7f4z72djuxdloupfvtn7nmr3c failed
==> Error: Failed to install zlib due to SyntaxError: invalid syntax (auth.py, line 121)
==> Error: cmake-3.20.4-d4anms4mhkpm4244d2zmzv3ityjb6hx6: Package was not installed
==> Error: Installation request failed.  Refer to reported errors for failing package(s).
The command '/bin/sh -c spack external find &&     spack install cmake@3.20.4' returned a non-zero code: 1

Error: Process completed with exit code 1.

This is from the merge into main: https://github.com/rse-radiuss/docker-images/actions/runs/1321731890. I guess we need to look for an auth.py?

vsoch commented 2 years ago

Good news - we've resolved issues with llvm 13! Bad news, some new error with hip?

==> Error: ProcessError: Command exited with status 2:
    'make' '-j2' 'V=1'
See build log for details:
  /tmp/root/spack-stage/spack-stage-mesa18-18.3.6-fezogr2nwx7qnrreyjaykrgror4jgmjk/spack-build-out.txt

==> Warning: Skipping build of hip-4.0.0-yxdtjodptoplrhmwjkitloln4yueuex5 since mesa18-18.3.6-fezogr2nwx7qnrreyjaykrgror4jgmjk failed
==> Warning: Skipping build of hip-rocclr-4.0.0-ldfbispsgu2yhgzoig6ukh6wwgcuctob since mesa18-18.3.6-fezogr2nwx7qnrreyjaykrgror4jgmjk failed
==> Error: hip-4.0.0-yxdtjodptoplrhmwjkitloln4yueuex5: Package was not installed
==> Error: Installation request failed.  Refer to reported errors for failing package(s).
The command '/bin/sh -c spack install hip@${hip_version}' returned a non-zero code: 1

Doesn't seem to be a lot of information there. :/

vsoch commented 2 years ago

okay just rebased with fixes for ubuntu 16.04 (the error was that Python 3.5 doesn't have format strings, which pkgconf expected)