rse-ops / docker-images

Collection of Docker image bases provided by the RSE-ops community.
https://rse-ops.github.io/docker-images/
MIT License
5 stars 8 forks source link

hip failing: meson no such file or directory #81

Open vsoch opened 2 years ago

vsoch commented 2 years ago

image

@trws what can I try to fix this?

trws commented 2 years ago

I think you did this already, but installing meson should do it. The "right" solution is probably to make sure that meson is a dependency in spack as well, probably in the MesonPackage build system.

vsoch commented 2 years ago

yep I think this is fixed! The new error is:

image

trws commented 2 years ago

Ah, that makes sense now. That's a bug in either the hip package or the upstream repos somewhere, it's an LLVM symbol that's not defined, so that's on them not us.

vsoch commented 2 years ago

Is there somewhere we can report it? I guess for the time being all our builds will fail because of it, at least until we can get a new version.

trws commented 2 years ago

Could report it on the spack repo. It might also be possible to specify a different gallium version in our build for a while if there's one that works, but it would take some experimentation to find one. What's the spec that's dying to cause this?

vsoch commented 2 years ago

Looks to be mesa!

==> Installing mesa-21.3.1-jyo4fe55ufprn73pu3eia7kp52iwrczk
==> No binary for mesa-21.3.1-jyo4fe55ufprn73pu3eia7kp52iwrczk found: installing from source
==> Fetching https://mirror.spack.io/_source-cache/archive/2b/2b0dc2540cb192525741d00f706dbc4586349185dafc[657](https://github.com/rse-ops/docker-images/runs/5458943568?check_suite_focus=true#step:8:657)29c7fda0800cc474d.tar.xz
==> Applied patch /opt/spack/var/spack/repos/builtin/packages/mesa/mesa_check_llvm_version_suffix.patch
==> mesa: Executing phase: 'meson'
==> mesa: Executing phase: 'build'
==> Error: ProcessError: Command exited with status 1:
    'ninja' '-j2' '-v'
trws commented 2 years ago

oh wait a minute, this might be because they changed their default to build with ~llvm instead of +llvm, maybe hip was counting on that being set?

vsoch commented 2 years ago

maybe - how do we fixit?

trws commented 2 years ago

If that's what it is, then adding ^mesa+llvm to the hip spec string should take care of it.

vsoch commented 2 years ago

Will try that!