search

rse-ops / docker-images

Collection of Docker image bases provided by the RSE-ops community.
https://rse-ops.github.io/docker-images/
MIT License
5 stars 8 forks source link

Update CMake to 3.23.1 #98

Closed davidbeckingsale closed 1 year ago

vsoch commented 1 year ago

Looks like this didn't trigger a build since we didn't change any files - should we do a trivial change to some of the containers to ensure the builds still work? E.g.,, add a changed comment or newline (or similar)?

davidbeckingsale commented 1 year ago

Looks like this didn't trigger a build since we didn't change any files - should we do a trivial change to some of the containers to ensure the builds still work? E.g.,, add a changed comment or newline (or similar)?

Will do!

vsoch commented 1 year ago

And next time we need to trigger, we can delete that comment :laughing:

rhornung67 commented 1 year ago

@davidbeckingsale was this change based on our discussion at the RAJA meeting yesterday? If so, we actually need cmake 3.23 for HIP.

Nevermind. I see that the code change is what we need. The title of this PR is wrong.

vsoch commented 1 year ago

Fixed!

davidbeckingsale commented 1 year ago

Whoops sorry about that, my fault.

rhornung67 commented 1 year ago

No worries. I was confused.