Naming in Demo not optimal

rse / componentjs

ComponentJS -- Powerful run-time Component System for structuring HTML5-based Rich Clients

http://componentjs.com/

Other

85 stars 13 forks source link

Naming in Demo not optimal #32

Closed lizzzzard closed 10 years ago

lizzzzard commented 10 years ago

The naming of two states and events in the demo ist not optimal. The following two values are defined in app-ui-login-model.js: "state:button-enabled" and "event:button-clicked".

As this file represents the model, it should be independent from any view realizing it - so the name "button" should not be used. A view could realize the Login activation with another ui element like a slider.

I propose "state:login-enabled" and "event:login-activated" as better names.

rse commented 10 years ago

Good catch! Now fixed by using the final names "state:login-allowed" and "event:login-requested". Thanks for reporting this subtle issue.