rse / node-prince

Node API for executing PrinceXML via prince(1) CLI
https://npmjs.com/prince
49 stars 24 forks source link

Check for installed prince version not working with v10r3-1 #3

Closed shanebell closed 9 years ago

shanebell commented 9 years ago

With version 10r3-1 of prince installed from http://www.princexml.com/download/ the regex check on line 63 of prince-npm.js does not work.

var m = stdout.match(/^Prince\s+(\d+\.\d+)/);

The version returned by $ prince --version is Prince 10 rev 3 which does not match the above. The code then goes on to download prince and install it even though it's already installed.

rse commented 9 years ago

Now fixed in version 1.1.4. Thanks for the hint.

shanebell commented 9 years ago

Awesome. Thanks for the speedy fix :)

On Wed, Jul 29, 2015 at 2:42 AM, Ralf S. Engelschall < notifications@github.com> wrote:

Now fixed in version 1.1.4. Thanks for the hint.

— Reply to this email directly or view it on GitHub https://github.com/rse/node-prince/issues/3#issuecomment-125675049.