search

rserota / wad

Web Audio DAW. Use the Web Audio API for dynamic sound synthesis. It's like jQuery for your ears.
MIT License
1.9k stars 160 forks source link

Added setPitch, proper indenting #50

Open vincurekf opened 9 years ago

vincurekf commented 9 years ago

I've just added Wad.prototype.setPitch() (it was not possible to set pitch to single wad on playback), and tried to correct indenting in code and unify it a bit to be easily readable.

rserota commented 9 years ago

I'm not sure what you mean by "proper" indenting. I think 2-space indentations and 4-space indentations are equally valid, but I personally find it uncomfortable to read code with 2-space indentations. I appreciate that you're adding a feature, but please leave the indentation and other aspects of formatting as they were.

phal0r commented 8 years ago

@rserota

Considering indentations, I would suggest tabs instead of whitespaces, so everybody can adjust his/her editor to display indentation as desired without changing the source code.

julianpoy commented 8 years ago

@phal0r When joining a new repository, it is typically the developers job to adapt to the coding standards and layout of the project.

phal0r commented 8 years ago

@julianpoy

Yeah, I totally agree. I didn't change it, I was just suggesting a good way :)

rserota commented 4 years ago

@phal0r WadJS has been updated to use tabs instead of spaces. Thanks for the suggestion.