search

rserota / wad

Web Audio DAW. Use the Web Audio API for dynamic sound synthesis. It's like jQuery for your ears.
MIT License
1.9k stars 160 forks source link

Made all the getUserMedia standard. #53

Closed ghost closed 8 years ago

ghost commented 8 years ago

You are using the deprecated version of getUserMedia, so it's making a warning. I made all the getUserMedia standard with my MediaStreamHelper.

If you want this library to fully support IE, then it needs polyfill codes for Promises(I didn't add it.), because IE does not support Promises.

P.S.: On the line 108: is })(window);; a correct code or a typo?

ghost commented 8 years ago

If you adopt this, Wad supports all the browsers that have a deprecated version or a standard version of getUserMedia.

rserota commented 8 years ago

Thanks for submitting this pull request. This looks like a great contribution, however it looks like you've edited the build version, and left the source version unchanged. If you could apply these changes to src/wad.js instead of build/wad.js, and then rebuild the library with grunt, that would be awesome.

I don't particularly care about supporting Internet explorer, though it would be nice to support Edge.

The extra semicolon on line 108 was put there by the build system. Grunt adds a semicolon between each file when they are concatenated, though I guess it wasn't necessary in this case.

ghost commented 8 years ago

Thank you and check my new pull-request: https://github.com/rserota/wad/pull/54!