search

rserota / wad

Web Audio DAW. Use the Web Audio API for dynamic sound synthesis. It's like jQuery for your ears.
MIT License
1.89k stars 160 forks source link

Added setDelay to set wad delay before and during playback #56

Closed torch2424 closed 8 years ago

torch2424 commented 8 years ago

Hello!

I recently went to a Hackathon (Hacktech 2016) with some buddies of mine @julianpoy and @AlexisLuter, and we made some live music performance software using Electron, AngularJS, and wad. And I found a couple of things that I implemented in the Hackathon that i was hoping to pull into wad to hopefully improve it. Thank you for making this awesome library, it was super fun to play with and we got a lot out of it.

Here is the Repo of what we made: https://github.com/julianpoy/HackTech2016

As well as a little Youtube demo: https://www.youtube.com/watch?v=7IH5IboZpwQ

So I will be making some pull requests slowly over time, as I'd love to contribute to this awesome project. and any feedback or suggestions would be much appreciated, thank you!

What this pull request does:

This simply adds to the set____ functions, and is similar to the setPanning() function, however it will allow for setting the delay during playback!

This was tested using the examples html as well as our program, and was working. It should allow for any wad's delay to be changed during playback. but any additioanl testing is much appreciated.

Thank You!

julianpoy commented 8 years ago

I was also part of this hackathon project, as mentioned. You will undoubtedly see pull requests from me too. Thank you for such a wonderful audio framework. It has allowed us to do unbelievable things with our software, and push the boundaries of Javascript's audio capability.

rserota commented 8 years ago

I'm glad you enjoyed using Wad.js at Hacktech! Your demo looks really cool.

This pull request looks great, and I'll happily merge it in. Thanks for contributing!