rserota / wad

Web Audio DAW. Use the Web Audio API for dynamic sound synthesis. It's like jQuery for your ears.
MIT License
1.89k stars 160 forks source link

allow for a -1 hold value on Oscillators so they never stop #90

Closed frastlin closed 6 years ago

frastlin commented 6 years ago

I don't want an oscillator to stop until I call stop() on it. the docs say:

    hold    : 3.14, // Time in seconds to maintain the sustain volume level. If this is not set to a lower value, oscillators must be manually stopped by calling their stop() method.

This makes it sound as if I set hold to 4, it will not stop until I call stop(). This is not the case, setting hold to 4 holds for 4 seconds. I would like a -1 value that allows the sound to play until I call stop on it.

rserota commented 6 years ago

Sure, why not.