rsertelon / iso-3166-country-codes-angular

Javascript lib for ISO 3166 Country codes
http://rsertelon.github.io/iso-3166-country-codes-angular
The Unlicense
34 stars 31 forks source link

Allows get the country's code giving its name #13

Closed dgdavid closed 9 years ago

dgdavid commented 9 years ago

I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

rsertelon commented 9 years ago

Hi,

Thanks for you PR :)

I've just one question for you, it's in the line notes ;)

Thanks!

rsertelon commented 9 years ago

Hmm I've just seen that this pull request is targeted on the master branch. In this project, I use the develop branch as default branch.

I won't merge this PR as is, but will cherry-pick you fix onto develop.

Thanks again ;)

rsertelon commented 9 years ago

I've cherry-picked your commit, but I forgot to ask you if you can confirm that this statement is okay for you:

I dedicate any and all copyright interest in this software to the
public domain. I make this dedication for the benefit of the public at
large and to the detriment of my heirs and successors. I intend this
dedication to be an overt act of relinquishment in perpetuity of all
present and future rights to this software under copyright law.

If so, please add it to the description of your PR.

Thanks !

dgdavid commented 9 years ago

Ok @rsertelon, done :)

Thanks!

rsertelon commented 9 years ago

Thank you ;) BTW, I released 1.1.1 with your contribution :)