search

rsertelon / iso-3166-country-codes-angular

Javascript lib for ISO 3166 Country codes
http://rsertelon.github.io/iso-3166-country-codes-angular
The Unlicense
34 stars 31 forks source link

Human readable form #19

Closed pieterbeulque closed 9 years ago

pieterbeulque commented 9 years ago

Have toUpperCase as an option instead of default? I know it diverges from the ISO standard.

I saw your discussion in issue #6 and pull request #10 but wanted to open this again.

Having it this way and calling toUpperCase() does the same thing as current behaviour, while the other way round (having Bouvet Island showing up as Bouvet Island is now easier than when it rendered as BOUVET ISLAND, neccessary steps being 1. toLowerCase() 2. CSS text-transform: capitalize).

rsertelon commented 9 years ago

I think as a library user it makes more sense. I was more worried (apart from the ISO stuff) that it would be difficult to maintain if I changed the case.

Merging for the sake of this library users, thanks for your contribution :)