Closed igorlino closed 6 years ago
@igorlino Thanks for the issue, I'd love the PR if you could. I'm mostly integrating patches and releasing the software now :)
Great, its here:
https://github.com/rsertelon/iso-3166-country-codes-angular/pull/29
At least the service is covered, and would already give nice code autocompletion for the country 🥇
if, you like the change, would you be so kind to make a new minor release, so that I can consume it? thanks
Merged, I'll try to release soon. Ping me if you don't see progress, I might forget about it unwillingly :)
Hi,
At the moment is not possible to cleanly integration this angular module with typescript, since there are not types available for it. (for example at: https://github.com/DefinitelyTyped/DefinitelyTyped)
There is an easy way to do it, if only including the definitions directly as part of the package.
For example moment.js includes them https://github.com/moment/moment/blob/develop/moment.d.ts
So something like:
dist/iso-3166-country-codes-angular.d.ts
Thanks.
PS: If you like, I can create them and make a pull request.