search

rsgalloway / pyseq

Compressed sequence string module for Python
https://pyseq.rsgalloway.com/
Other
123 stars 36 forks source link

Upstream #28

Closed nebukadhezer closed 8 years ago

nebukadhezer commented 8 years ago

Hey Ryan,

a small PR regarding formatting I added %M to be able to show missing frames in a similar manner as %R... Added a unittest and made them semi crossplatform (lss is obviously failing on windows, though I d like to make a lss.bat...)

All the best Johannes

rsgalloway commented 8 years ago

Looks good, nice idea. One minor comment:

def _get_framerange(self, input, missing=True):

Instead of input being a function, maybe it'd be cleaner to just have this argument be a list, and call it frames?

def _get_framerange(self, frames, missing=True):

Then you can pass in either self.missing(), or self.frames() (or any list, really) and you can also remove line :723. Don't forget to update the docstring for that function :)

rsgalloway commented 8 years ago

Thanks!