search

rsgalloway / pyseq

Compressed sequence string module for Python
https://pyseq.rsgalloway.com/
Other
123 stars 36 forks source link

Win lss #29

Closed nebukadhezer closed 7 years ago

nebukadhezer commented 8 years ago

Hey Ryan,

added an lss.bat for win, I only have windows 7 at hand. Obviously python has to be in the PATH envvar in order to execute like this...

Cheers Johannes

nebukadhezer commented 7 years ago

I guess I ll close this now? cheers

rsgalloway commented 7 years ago

Hi Johannes, sorry for not responding. Is the universal_newlines meant to give better unicode support? For the .bat file, it's so simple I'm unsure of the value of including it in the repo. Seems like if a windows user needs that it would be trivial to write.

nebukadhezer commented 7 years ago

Hi, When stdout or stderr are pipes and universal_newlines is True then all line endings will be converted to '\n' .... this is from the docs, it is just to make sure the unittest is not failing. sometimes newline would be '\r\n'... And yes the bat is minimal and easily replicated. Cheers

rsgalloway commented 7 years ago

If you submit a new PR for 56d694efc4d952d8761259daedd29613fb104ba6 I'll merge that.