search

rsgalloway / pyseq

Compressed sequence string module for Python
https://pyseq.rsgalloway.com/
Other
123 stars 36 forks source link

x syntax support #47

Open nebukadhezer opened 6 years ago

nebukadhezer commented 6 years ago

Hello Ryan,

this is a working implementation of additional stepping formating options. #7 I am not a mathematician, so I guess this is done in a very basic and rudimentary way. But the unittests hopefully show the variety that can exist once one dives into the land of stepping syntax.

The way it is implemented now, we often create the FrameRange object (which should slow things down). If this is something that you want to merge, I would make the FrameRange object a property on Sequence and then I would need to go over, append and insert, etc to make sure the FrameRange object is up to date.

All the best Johannes

rsgalloway commented 6 years ago

Hey, very interesting, this is great to see, thank you. Performance is definitely one of, if not the most, important considerations, so it would be good to add some performance regressions tests to the unit tests as well, something which we don't currently have, but should have. If we had that, it would be easier to evaluate big changes like this. I'll take a closer look asap.

nebukadhezer commented 6 years ago

Hey, yes would be good to have speed indicators in the unittests. I only have used gitlabs CI/CD stuff, but I guess github is somewhat similiar. I think I read somewhere that runners are free at gitlab for open source projects.. but I might be wrong..

nebukadhezer commented 5 years ago

I hope I do have some time the next weeks to update this PR.. sorry it took so long.