rsheftel / pandas_market_calendars

Exchange calendars to use with pandas for trading applications
MIT License
804 stars 173 forks source link

XNSE and XBOM holiday 2024-05-20 #344

Open npezolano opened 5 months ago

npezolano commented 5 months ago

2024-05-20 was election day in Indian and both XBOM and XNSE were closed

https://www.nseindia.com/resources/exchange-communication-holidays https://www.bseindia.com/static/markets/marketinfo/listholi.aspx

start = '2024-05-18'
end = '2024-05-21'
cal = mcal.get_calendar('XNSE')
print(cal.schedule(start_date=start, end_date=end))
rsheftel commented 5 months ago

Those calendars are defined in the exchange_calendars package. I recommend submitting an issue there

https://github.com/gerrymanoim/exchange_calendars

npezolano commented 5 months ago

Should probably remove the alias for XNSE and NSE under the BSE calendar here, the two exchanges vary on holidays.

https://github.com/rsheftel/pandas_market_calendars/blob/939e7e6c184515cdbfe6dda22cf363b286a043ab/pandas_market_calendars/calendars/bse.py#L405

Should I create a separate NSE/XNSE calendar here or in the exchange_calendars repo?