search

rsheldiii / KeyV2

KeyV2: A Parametric Mechanical Keycap Library
GNU General Public License v3.0
1.44k stars 186 forks source link

Please suggest "cherry_stabilizer" for stabilized() #4

Open thenickdude opened 5 years ago

thenickdude commented 5 years ago

The wiki suggests using "cherry" in the "type" argument for stabilized(), but this will generate extra cherry keystems rather than cherry stabilizers (which super duper don't fit on my Cherry-stabilized Pok3r).

I think this should be suggesting "cherry_stabilizer"?

SvDvorak commented 5 years ago

I'd very much appreciate this as well.

rsheldiii commented 4 years ago

sorry for the late response, notifications to this repo have been going to the wrong email. The docs are wrong, and the situation is definitely confusing; the docs should say costar_stabilizer instead of cherry there.

Since costar stabilizers use inserts they can just be inserted into another full cherry stem, and benefit from the extra plastic, since it's the most delicate piece of the puzzle. I made the costar_stabilizer stem type alias to a cherry stem for that, and made it the default, since anecdotally I found most boards to use costar stabilizers.

I've updated the docs to clarify and fix the omission. I'm going to look into defaulting to cherry_stabilizer since it should work with both types, whereas costar_stabilizer will not, but I want to print a couple test pieces first to make sure.

Thanks for pointing this out!

SvDvorak commented 4 years ago

Thanks for looking into this and clearing it up! I got around the issue by just modifying the model after generating it, they printed fine for me but as you say, they get pretty thin and might be tricky to print for others. But having it as an option would be nice.